Skip to content

Address type safety, React patterns, and Dockerfile security issues - #11

Merged
miccy merged 2 commits into
sync/bun-migrationfrom
copilot/sub-pr-5-again
Feb 3, 2026
Merged

Address type safety, React patterns, and Dockerfile security issues#11
miccy merged 2 commits into
sync/bun-migrationfrom
copilot/sub-pr-5-again

Conversation

Copilot AI commented Feb 3, 2026

Copy link
Copy Markdown

Addresses 9 review comments from PR #5 covering type safety violations, React antipatterns, and supply chain security concerns.

Type Safety

  • MainTask return type: Changed to void | undefined to allow both ok() and ok(undefined) without forcing callers to choose
  • pool function: Removed any cast—AbortError.is() type guard properly narrows to include .reason property
  • Schema.ts: Removed unused Timestamp import

React Patterns

  • SectionProvider: Fixed Rules of Hooks violation—replaced conditional useStore call with fallback empty store pattern:
    const store = useContext(SectionStoreContext);
    return useStore(store ?? emptyStore, selector);
  • Search: Added pathname/searchParams to effect dependencies to close dialog on navigation

Security

  • Dockerfile: Pinned turbo version using bunx turbo@2.8.2 instead of unpinned bun install -g turbo to prevent supply chain attacks in both builder and installer stages

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: miccy <9729864+miccy@users.noreply.github.com>
Copilot AI changed the title [WIP] Update migration documentation for Bun and Biome Address type safety, React patterns, and Dockerfile security issues Feb 3, 2026
Copilot AI requested a review from miccy February 3, 2026 13:44
@miccy
miccy marked this pull request as ready for review February 3, 2026 13:55
@coderabbitai

coderabbitai Bot commented Feb 3, 2026

Copy link
Copy Markdown

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • 🔍 Trigger a full review

Comment @coderabbitai help to get the list of available commands and usage tips.

@miccy
miccy merged commit 07e757b into sync/bun-migration Feb 3, 2026
2 checks passed
@miccy
miccy deleted the copilot/sub-pr-5-again branch February 3, 2026 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants