Skip to content
This repository was archived by the owner on Aug 17, 2020. It is now read-only.

Refactored settings page#1522

Open
Markusch85 wants to merge 4 commits intoST-Apps:masterfrom
Markusch85:settings-version
Open

Refactored settings page#1522
Markusch85 wants to merge 4 commits intoST-Apps:masterfrom
Markusch85:settings-version

Conversation

@Markusch85
Copy link
Copy Markdown

@Markusch85 Markusch85 commented Sep 1, 2016 •
edited
Loading

Changes

  • Refactored Settings page -- Replaced Grid with RelativePanel
  • Added in Settings Page some Basic styles for this page and their controls

Matthias Heilhecker added 2 commits September 1, 2016 19:26
@Markusch85 Markusch85 changed the title Settings version Added version to settings and refactored the page Sep 1, 2016
@Rover656
Copy link
Copy Markdown

Rover656 commented Sep 2, 2016

LGTM

@kzadorAT
Copy link
Copy Markdown

kzadorAT commented Sep 3, 2016

The version number is repeated two times. Sorry for my elemental english.

@Rover656
Copy link
Copy Markdown

Rover656 commented Sep 3, 2016

@kzadorAT It is supposed to be, going by the code

@Markusch85
Copy link
Copy Markdown
Author

Markusch85 commented Sep 4, 2016 •
edited
Loading

@kzadorAT You were right. There was a bug, some days before, which was already fixed. I've updated the screenshot.

Update: I've reverted my Version, because another PR implemented this Feature: #1499

@Markusch85 Markusch85 changed the title Added version to settings and refactored the page Refactored settings page Sep 4, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Markusch85 @Rover656 @kzadorAT