This repository was archived by the owner on Aug 17, 2020. It is now read-only.
Added new PoGoBaseViewModel#1616
Open
Markusch85 wants to merge 4 commits intoST-Apps:masterfrom
Markusch85:PoGoViewModelBase
Open
Added new PoGoBaseViewModel#1616Markusch85 wants to merge 4 commits intoST-Apps:masterfrom Markusch85:PoGoViewModelBase
Markusch85 wants to merge 4 commits intoST-Apps:masterfrom
Markusch85:PoGoViewModelBase
Conversation
Collaborator
|
This is cool. I don't know if it's going to get accepted for 1.1, but we are doing something similar for the 2.0 architecture. It's going to use Dependency Injection to inject different game services into the different ViewModels, which you'll be able to bind to directly. Should make things orders of magnitude more simple. |
Author
|
Nice to hear, that you are working on dependency injection for Version 2.0 can I help you implementing that? |
|
What will be implement in the next update? Obs: My English sucks I know, sorry!🙂 |
|
@Jehu147 @trainerfloripa Please no questions regarding when the next release will come. It is ready when it is ready. |
|
@trainerfloripa Don't worry about your English you don't have to speak it here it's just that lots of people do. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes issues
no issues to close
Changes
Change details
The new PoGoViewModelBase is an Abstract ViewModel which ca be implemted by other ViewModels. Currently it handles Standard Lifecycycles for:
and Bindable Game Vars for:
Other informations
If anyone have to use the standard implementation of the above called Vars and LifeCycle methods, the one can use the PoGoViewModelBase.
Another reason, why I've added the new ViewModel is, that we reduce duplicate Code.