Add muliple point cloud registration to OpenGR#51
Open
beautifulv0id wants to merge 19 commits intoSTORM-IRIT:masterfrom
Open
Add muliple point cloud registration to OpenGR#51beautifulv0id wants to merge 19 commits intoSTORM-IRIT:masterfrom
beautifulv0id wants to merge 19 commits intoSTORM-IRIT:masterfrom
Conversation
620ed69 to
b4ca0d4
Compare
This was referenced Aug 28, 2020
e04f35e to
bc7e15d
Compare
|
Hi @beautifulv0id , I know it's been a while, but I try to add your code to OpenGR's master branch. add_custom_command(TARGET copy_gret_sdp_data
POST_BUILD
COMMAND ${CMAKE_COMMAND} -E make_directory ${GRET_SDP_DATA_DIR_TO}
COMMAND ${CMAKE_COMMAND} -E copy ${GRET_SDP_DATA_DIR_FROM}/* ${GRET_SDP_DATA_DIR_TO}/.
)Do you still have this data somewhere ? Best |
Author
|
Hey Nicolas,
I’m very happy to hear that. I should still have it. I’m not at home right now, so I’ll have a look at it when I’m back in Monday and let you know. If its not there I’ll just generate new data.
Cheers Felix
|
|
Good to hear back from you. |
Author
|
I had a look at the test again. I think I just used the bunny from the standard stanford 3D scanning repository and did not generate the data myself. The download link can be found here http://graphics.stanford.edu/data/3Dscanrep/ <http://graphics.stanford.edu/data/3Dscanrep/>. Does that work? Sorry, I can’t try it by myself right now.
|
Author
|
Using the bunny should be fine. The test constructs patches itself from the ground truth transformations. Let me know if you need anything more.
|
Now, AbstractMatchBase (AMB) contains all the generic code, i.e. logger, options (crtp) and PosMutablePoint. PairwiseMatchBase (PMB) extends AMB and contains code for pairwise matching algorithms. In the future, a class that contains all the generic code for multiple point cloud registration will be added.
Make wrappers available depending on the desired backend
variables are: OpenGR_USE_SDPA and OpenGR_USE_MOSEK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.