final edits - #109
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Tightens AI safety/robustness around n8n structured responses by returning explicit refusal/clarification results instead of falling back to mock intent detection, and adds parameter-clarification guards before executing genre/profile-based actions.
Changes:
- Update n8n response validation to return a safe refusal for unknown intents and a safe clarification for malformed structured payloads.
- Add “missing required parameter” clarification branches in
AiActionServicefor several genre/profile-driven intents. - Update/add unit tests to cover the new refusal/clarification behaviors.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/ai/providers/n8n-ai.provider.ts | Returns explicit refusal/clarification results for unknown/malformed n8n responses. |
| src/ai/ai.service.spec.ts | Updates n8n helper tests for new refusal behavior; adds malformed payload clarification test. |
| src/ai/ai-action.service.ts | Adds early clarification responses when required params (genre/profile/artist) are missing. |
| src/ai/ai-action.service.spec.ts | Adds test ensuring missing required n8n parameters do not execute playlist creation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -58,7 +58,14 @@ export function validateStructuredAiResponse(raw: unknown, message: string, cont | |||
| // Reject unknown or non-whitelisted intents | |||
| if (!intent || !(ALLOWED_INTENTS as readonly string[]).includes(intent)) { | |||
| logger.warn(`[N8N] Unknown intent "${intent}" — falling back to mock`); | |||
Comment on lines
+389
to
+400
| const genre = this.cleanString(params.genre); | ||
| const limit = this.safeLimit(params.limit, 5); | ||
|
|
||
| if (!genre) { | ||
| return { | ||
| reply: 'Which genre should I search for?', | ||
| provider, | ||
| intent: 'recommend_by_genre', | ||
| actionsTaken: [], | ||
| needsConfirmation: true, | ||
| }; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
@copilot apply changes based on this feedback
Contributor
There was a problem hiding this comment.
Added the missing-genre test in commit 0aedcae. The test covers the recommend_by_genre missing-genre branch by asserting that:
- The response has
needsConfirmation: trueand the reply contains "genre" - Neither
prisma.track.findManynorprisma.genre.findManyare called (no DB queries executed)
Agent-Logs-Url: https://github.com/SWE-Team-9/Backend/sessions/ad00c089-b278-4a4c-8504-710d34fc133f Co-authored-by: MohanEhab <157999295+MohanEhab@users.noreply.github.com>
Contributor
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.