Conversation
826193720
force-pushed
the
ljl
branch
2 times, most recently
from
April 27, 2026 02:59
ba28c99 to
268d874
Compare
added 3 commits
April 27, 2026 16:11
SWangHash
pushed a commit
that referenced
this pull request
Aug 31, 2026
…arden adapter fence Address PR GCWing#2428 review round 3 (issues #1-#3): 1. CLI peer host lacked a `cancel_tool` route. Expose `cancel_tool` on `CoreAgentRuntimeCompatibility` (delegates to the coordinator), add the CLI dialog handler + dispatch branch, and advertise the `cancel_tool` capability in both desktop and CLI `peer_mode_ping`. 2. CLI peer host lacked a `get_all_tools_info` route and the tool-info DTO was duplicated between desktop and core. Add a shared `ToolInfoDto` + `build_tool_info`/`build_all_tools_info` in core (backed by the global tool registry), a thin CLI `tools` handler + dispatch branch, and the `tool_catalog` capability in both `peer_mode_ping` surfaces. Desktop's `tool_api` now aliases the core DTO instead of redefining it. 3. The ESLint adapter fence leaked: a global `ignores` entry for `src/shared/context-system/core/types/**` let direct/dynamic `invoke` imports pass lint there. Drop the blanket ignore and add a targeted override that exempts only `react-hooks/rules-of-hooks`; the fence rules now apply. Add a config-level regression test pinning that both the ordinary business dir and the context-system types dir block invoke, while the adapter exception still permits it. Frontend: propagate `cancelTool`/`toolCatalog` capabilities through the peer-device snapshot/context, gate the Terminal interrupt button and the tool-catalog fetches (useAgentsList, AssistantDefaultsPage) on host support; default to allowed when capabilities are unknown to avoid flicker. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
support oh ide base