Repository navigation
Implement deleteWorkspace functionality in WorkspaceProvider - #104
Merged
Merged
Conversation
- Add deleteWorkspace to WorkspaceProvider useState initializers (both success and fallback branches) so it matches WorkspaceContextValue. - Add deleteWorkspace implementation in createGlobalStateAPI delegating to globalAPI.deleteWorkspace. - Fix react-hooks/rules-of-hooks violation in ReadFileDisplay by moving useState before the conditional early return.
…dd zh-CN/zh-TW i18n - delete_workspace Rust command now recursively deletes the workspace root_path for local workspaces; remote workspaces skip disk deletion. - Add is_unsafe_workspace_deletion_path guard to refuse filesystem roots and relative paths. - Close the confirm dialog after a successful deletion so the UI reflects the action immediately. - Add missing zh-CN/zh-TW translations for deleteWorkspace, deleteWorkspaceFailed, workspaceDeleted, and deleteWorkspaceDialog, and update the dialog message across all locales to reflect the destructive behavior.
…lete dialog Move the workspace rootPath into the message body as monospace text instead of using the preview block, removing the 'Workspace Path' label, background color, and border while keeping the path at a smaller font size (font-size-xs) than the message body.
SWangHash
force-pushed
the
wc/delete_workspace
branch
from
June 22, 2026 09:06
c219fac to
9773ee7
Compare
…nt workspace When the active workspace is an assistant workspace (auto-activated on startup) or no workspace is open, default the New Project dialog parent path to /storage/Users/currentUser/Documents instead of the assistant workspace directory.
Wrap the workspace rootPath in a subtle bg-subtle block with padding and rounded corners for better visual separation from the message text.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #
Type and Areas
Type:
Areas:
Motivation / Impact
Verification
Reviewer Notes
Checklist