Repository navigation
Conversation
2 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves Web UI E2E test locator coverage for OHOS automation. It restores missing navigation/skills locators and adds richer
data-*attributes for chat model selection and settings model configuration flows, with matching documentation updates.Changes
Restore OHOS E2E locators
nav-session-menu-btn,nav-session-menu,nav-session-menu-rename, andnav-session-menu-delete, withdata-session-idon menu-related nodesskills-tab-installed,skills-tab-discover) and panel locators (skills-installed-panel,skills-discover-panel), withdata-skills-tab-activeon tabsStrengthen model locator semantics
ModelSelector: adddata-option-kind,data-model-role, anddata-provider-idfor auto / primary / fast alias / ACP / normal model entries; alias entries also exposedata-resolved-*fieldsAIModelConfig: add structured locator metadata (data-option-kind,data-model-role,data-model-state,data-model-source,data-provider-id,data-config-id) for selectable options, selected drafts, saved models, and test-status nodesdocs/development/ui-testids.mdandui-testids-CN.mdwith the new attributes and locator guidanceMotivation
OHOS E2E tests need stable, unambiguous DOM selectors. Visible text and
data-model-namealone are not reliable unique keys—especially for alias entries (auto,primary,fast) and multi-provider model lists.Test plan
data-testid+data-session-idskills-tab-*and panel visibility viaskills-*-paneldata-option-kind/data-model-roledata-*attributespnpm run type-check:webMerge notes
main; no conflicts expected