Repository navigation
Refactor CLI to decouple canvas-runtime and drop oxc dependency - #115
Merged
Merged
Conversation
… from cli canvas-runtime (which pulls oxc 0.137.0, MSRV 1.94) was forced into the CLI build via two product-full paths: bitfun-core product-full and bitfun-services-integrations product-full. The CLI does not use canvas; only desktop does. - Remove canvas-runtime from bitfun-core and services-integrations product-full feature lists - Drop canvas-runtime from services-integrations requiredProductFullFeatures boundary rule to keep check-core-boundaries green - Add canvas-runtime explicitly to desktop's bitfun-core features so desktop keeps full canvas support This lets bitfun-cli build on Rust 1.89 (oxc no longer in its dep graph).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… from cli
canvas-runtime (which pulls oxc 0.137.0, MSRV 1.94) was forced into the CLI build via two product-full paths: bitfun-core product-full and bitfun-services-integrations product-full. The CLI does not use canvas; only desktop does.
This lets bitfun-cli build on Rust 1.89 (oxc no longer in its dep graph).
Summary
Fixes #
Type and Areas
Type:
Areas:
Motivation / Impact
Verification
Reviewer Notes
Checklist