Repository navigation
Conversation
…and agent commands Persist a user-editable 'terminal.env_vars' map and expose it in Settings (BasicsConfig) as an editable Key/Value table with one-click import from .env-style files (KEY=VALUE / export KEY=VALUE / KEY:VALUE, skipping #-comments). Inject the vars live at three execution paths so changes take effect for new sessions without restart: new terminal sessions (terminal_create), agent bash sessions (bash_tool), and one-shot agent ExecCommand runs. Already-open sessions are unaffected, matching existing terminal config behavior. Add 'load_terminal_env_vars' helper in bitfun-core config; add env_vars field to the persisted TerminalConfig (serde-default, backward compatible); add i18n keys (en-US/zh-CN/zh-TW) under terminal.envVars.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…and agent commands
Persist a user-editable 'terminal.env_vars' map and expose it in Settings (BasicsConfig) as an editable Key/Value table with one-click import from .env-style files (KEY=VALUE / export KEY=VALUE / KEY:VALUE, skipping #-comments).
Inject the vars live at three execution paths so changes take effect for new sessions without restart: new terminal sessions (terminal_create), agent bash sessions (bash_tool), and one-shot agent ExecCommand runs. Already-open sessions are unaffected, matching existing terminal config behavior.
Add 'load_terminal_env_vars' helper in bitfun-core config; add env_vars field to the persisted TerminalConfig (serde-default, backward compatible); add i18n keys (en-US/zh-CN/zh-TW) under terminal.envVars.
Summary
Fixes #
Type and Areas
Type:
Areas:
Motivation / Impact
Verification
Reviewer Notes
Checklist