Repository navigation
version update - #120
Merged
Merged
version update#120
Conversation
Signed-off-by: yujiangtao <yujiangtao11@h-partners.com>
SWangHash
pushed a commit
that referenced
this pull request
Sep 1, 2026
fix(review): export markdown reports on HarmonyOS Created-by: guantw Commit-by: guantw Merged-by: SWangHash Description: ## Summary Fix HarmonyOS review Markdown export when browser download APIs are unavailable. - Route review report exports through a shared save-text helper that prefers browser downloads and falls back to the host save dialog. - Add the desktop save command and register it across remote-workspace and peer-device command boundaries. - Bridge the HarmonyOS save dialog result to ArkTS file persistence while preserving browser behavior on supported surfaces. - Add regression coverage for review export actions, the System API, and the save helper. Fixes #120 ## Type and Areas Type: Bug fix Areas: Web UI, desktop/Tauri, HarmonyOS, peer-device and remote-workspace adapters ## Motivation / Impact HarmonyOS WebView does not provide the browser download path used by review report export, so Markdown reports could not be saved. This change falls back to the host file dialog and writes the selected file through the platform adapter without changing the normal browser download path. ## Verification - `pnpm --dir src/web-ui exec vitest run src/flow_chat/tool-cards/CodeReviewReportExportActions.test.tsx src/infrastructure/api/service-api/SystemAPI.test.ts src/infrastructure/services/infra/saveTextFileWithDialog.test.ts` — 17 tests passed in 3 files. - `pnpm --dir src/web-ui run gen:types` — 34 Rust schema/export tests passed and 45 API re-exports were generated. - `pnpm run type-check:web` — passed. - `pnpm run prepare:mobile-web` — passed. - `cargo check -p bitfun-desktop` — attempted, but blocked by pre-existing `release/1.0.5` default desktop feature/dependency inconsistencies. ## Reviewer Notes - The desktop manifest change only adds the dialog plugin required by this fix. - Normal browser downloads remain unchanged; the host dialog is used only when the browser download path is unavailable. - No live remote-workspace, remote-control, peer-device, or detached-dispatch end-to-end run was performed. - The change rebased cleanly onto `release/1.0.5` at `3245938c1`. ## Checklist - [x] This PR is focused and does not include secrets, temporary prompts, generated scratch files, or unrelated artifacts. - [x] Relevant verification is recorded above, or skipped checks are explained. - [x] User-facing strings, docs, and locales are updated where applicable. See merge request: OpenHarmonyPCDeveloper/BitFun!94
SWangHash
pushed a commit
that referenced
this pull request
Sep 2, 2026
fix(review): export markdown reports on HarmonyOS Created-by: guantw Commit-by: guantw Merged-by: SWangHash Description: ## Summary Fix HarmonyOS review Markdown export when browser download APIs are unavailable. - Route review report exports through a shared save-text helper that prefers browser downloads and falls back to the host save dialog. - Add the desktop save command and register it across remote-workspace and peer-device command boundaries. - Bridge the HarmonyOS save dialog result to ArkTS file persistence while preserving browser behavior on supported surfaces. - Add regression coverage for review export actions, the System API, and the save helper. Fixes #120 ## Type and Areas Type: Bug fix Areas: Web UI, desktop/Tauri, HarmonyOS, peer-device and remote-workspace adapters ## Motivation / Impact HarmonyOS WebView does not provide the browser download path used by review report export, so Markdown reports could not be saved. This change falls back to the host file dialog and writes the selected file through the platform adapter without changing the normal browser download path. ## Verification - `pnpm --dir src/web-ui exec vitest run src/flow_chat/tool-cards/CodeReviewReportExportActions.test.tsx src/infrastructure/api/service-api/SystemAPI.test.ts src/infrastructure/services/infra/saveTextFileWithDialog.test.ts` — 17 tests passed in 3 files. - `pnpm run type-check:web` — passed. - `git show --check --oneline 802a37a` — passed. - Rust schema/build verification was attempted but did not complete in this worktree: the Linux rustup installation has no configured toolchain, while the available Windows Cargo reports that the current `main` lockfile would need an update under `--locked`. `Cargo.lock` was intentionally left unchanged. ## Reviewer Notes - This ports the functional change from #94 onto `main` at `40f4fee26`. - `main` already provides `tauri-plugin-dialog` globally, so this branch does not duplicate the release-branch manifest or lockfile changes. - The save dialog remains controller-local in Peer Device Mode and is explicitly `LocalOnly` for remote workspaces. - No live HarmonyOS device, remote-workspace, remote-control, peer-device, or detached-dispatch end-to-end run was performed. ## Checklist - [x] This PR is focused and does not include secrets, temporary prompts, generated scratch files, or unrelated artifacts. - [x] Relevant verification is recorded above, or skipped checks are explained. - [x] User-facing strings, docs, and locales are updated where applicable. See merge request: OpenHarmonyPCDeveloper/BitFun!102
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #
Type and Areas
Type:
Areas:
Motivation / Impact
Verification
Reviewer Notes
Checklist