Skip to content

fix(web): keep feedback dialog within window bounds - #235

Merged
SWangHash merged 1 commit into
SWangHash:mainfrom
Peanut-Puff:ohos
Aug 17, 2026
Merged

SWangHash merged 1 commit into
SWangHash:mainfrom
Peanut-Puff:ohos

Conversation

@Peanut-Puff

Copy link
Copy Markdown

Summary

  • Add instance-scoped Modal dimensions that take precedence over late Appearance size presets.
  • Keep the Feedback dialog within host window bounds with responsive padding, bounded height, and a compact completion state.
  • Preserve usable footer actions at narrow sizes and expand focused regression coverage.

Type and Areas

Type: Bug fix / UI/UX / test
Areas: Web UI, component library

Motivation / Impact

Prevents the Feedback dialog from exceeding the host window and prevents late Appearance runtime rules from overriding its constraints. Narrow or short windows keep actions accessible, while the completion view remains compact.

AI-assisted: Yes. Testing level: automated checks plus manual simulator and physical-device validation.

Verification

  • pnpm run type-check:web
  • pnpm --dir src/web-ui run test:run src/component-library/components/Modal/Modal.test.tsx src/app/components/FeedbackDialog/feedbackSubmissionContract.test.ts
    • 2 test files passed
    • 17 tests passed
  • Manually verified the Feedback dialog on a HarmonyOS simulator and a physical HarmonyOS device.

Reviewer Notes

  • The dimensions style is intentionally inline so instance constraints outrank Appearance size presets.
  • No user-facing copy or locale resources changed.

Checklist

  • This PR is focused and does not include secrets, temporary prompts, generated scratch files, or unrelated artifacts.
  • Relevant verification is recorded above, or skipped checks are explained.
  • User-facing strings, docs, and locales are updated where applicable.

@SWangHash
SWangHash merged commit af67ddc into SWangHash:main Aug 17, 2026
2 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants