Conversation
SWangHash
pushed a commit
that referenced
this pull request
Aug 31, 2026
…adapter surface PR GCWing#2428 review #4 (limityan, 2026-08-25). All but the truncated PR-title P3. P1: - Browser Control / Computer Use now run on the host that runs the Tool: removed browser_control_*/computer_use_get_status/request_permissions/ open_system_settings from FE + Desktop LOCAL_ONLY; CLI deny.rs already refuses them. Desktop Peer B bridges to its own webview (reads B's browser/OS); SessionConfig surfaces an explicit unsupported notice on a CLI Peer instead of silent invoke failures. browser_webview_* stays controller-local (embedded UI). - cancel_tool joins HIGH_PRIORITY_COMMANDS so Terminal Interrupt takes the reserved high slot instead of queueing behind saturated normal work. - Tool catalog request bound to Device Surface: renderedPeerDeviceId added to useAgentsList loadAgents deps + AssistantDefaultsPage effect, so A->B (same workspace + capability) reloads; requestId guard drops stale results. P2: - Capability versioning: cancelTool/toolCatalog become boolean|null (null = unknown/older host); consumers stay optimistic so an older Desktop keeps its working button/list instead of being gated off. - Tool catalog status tri-state (available/unsupported/failed/empty) in useAgentsList + AssistantDefaultsPage; AssistantDefaultsPage distinguishes failure from a truly empty list. - keepalive publishes a React snapshot when a ready peer's capabilities change (not only on recovery), via capabilitiesEqual(). P3: - Remove two unreachable-pub identity fns + unused import from catalog.rs. - eslint fence regression test runs the eslint JS bin via process.execPath with shell:false (was pnpm + shell:true -> Node DEP0190 on Windows). Verified: eslint src clean; focus tests 72/72 (adapter 42, manager 19, surface + fence); core-boundaries + 126 self-tests pass; cargo build core/desktop clean; desktop peer_host_invoke 6/6; CLI cli_command_contracts 41/41. Pre-existing @generated/api type error and 2 flaky terminal_process contract tests are unrelated. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix white screen