Skip to content

fix the bug #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SWangHash merged 2 commits into from
May 23, 2026
Merged

fix the bug #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
27f1c33
[bugfix] add git availability check for coding-selfie miniapp
SWangHash May 23, 2026
3d9e39e
[feature] hide ACP Agent settings from settings nav
SWangHash May 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,7 @@ Desktop is built on Tauri for Windows / macOS / Linux; remote control works from
- [pnpm](https://pnpm.io/)
- [Rust toolchain](https://rustup.rs/)
- [Tauri prerequisites](https://v2.tauri.app/start/prerequisites/) (required for desktop development)
- [ohos-rs](https://ohos.rs/docs/basic/quick-start)

**Commands:**

Expand Down
1 change: 1 addition & 0 deletions README.zh-CN.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,7 @@ Agent 领域几乎每周都有新范式出现。BitFun 的节奏是——**看
- [pnpm](https://pnpm.io/)
- [Rust 工具链](https://rustup.rs/)
- [Tauri 前置依赖](https://v2.tauri.app/start/prerequisites/)（桌面端开发需要）
- [ohos-rs](https://ohos.rs/docs/basic/quick-start)

**运行指令：**

Expand Down
4 changes: 2 additions & 2 deletions src/web-ui/src/app/scenes/settings/SettingsScene.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import {
SessionPermissionsConfig,
} from '../../../infrastructure/config/components/SessionConfig';
import McpToolsConfig from '../../../infrastructure/config/components/McpToolsConfig';
import AcpAgentsConfig from '../../../infrastructure/config/components/AcpAgentsConfig';
// import AcpAgentsConfig from '../../../infrastructure/config/components/AcpAgentsConfig'; // temporarily hidden
import EditorConfig from '../../../infrastructure/config/components/EditorConfig';
import BasicsConfig from '../../../infrastructure/config/components/BasicsConfig';
import AppearanceConfig from '../../../infrastructure/config/components/AppearanceConfig';
Expand Down Expand Up @@ -61,7 +61,7 @@ const SettingsScene: React.FC = () => {
case 'quick-actions': Content = QuickActionsConfig; break;
case 'review': Content = ReviewConfig; break;
case 'mcp-tools': Content = McpToolsConfig; break;
case 'acp-agents': Content = AcpAgentsConfig; break;
// case 'acp-agents': Content = AcpAgentsConfig; break; // temporarily hidden
case 'editor': Content = EditorConfig; break;
}

Expand Down
32 changes: 17 additions & 15 deletions src/web-ui/src/app/scenes/settings/settingsConfig.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ export type ConfigTab =
| 'quick-actions'
| 'review'
| 'mcp-tools'
| 'acp-agents'
// | 'acp-agents' // temporarily hidden from config center
// | 'lsp' // temporarily hidden from config center
| 'editor'
| 'keyboard';
Expand Down Expand Up @@ -192,20 +192,21 @@ export const SETTINGS_CATEGORIES: ConfigCategoryDef[] = [
descriptionKey: 'configCenter.tabDescriptions.mcpTools',
keywords: ['mcp', 'server', 'plugin', 'stdio', 'sse', 'tools'],
},
{
id: 'acp-agents',
labelKey: 'configCenter.tabs.acpAgents',
descriptionKey: 'configCenter.tabDescriptions.acpAgents',
keywords: [
'acp',
'agent client protocol',
'external agent',
'opencode',
'claude code',
'codex',
'stdio',
],
},
// ACP Agent settings — temporarily hidden from nav
// {
// id: 'acp-agents',
// labelKey: 'configCenter.tabs.acpAgents',
// descriptionKey: 'configCenter.tabDescriptions.acpAgents',
// keywords: [
// 'acp',
// 'agent client protocol',
// 'external agent',
// 'opencode',
// 'claude code',
// 'codex',
// 'stdio',
// ],
// },
],
},
{
Expand Down Expand Up @@ -247,6 +248,7 @@ export function normalizeSettingsTab(section: string): ConfigTab {
if (section === 'theme' || section === 'font' || section === 'fonts') return 'appearance';
if (section === 'logging' || section === 'terminal') return 'basics';
if (section === 'lsp') return DEFAULT_SETTINGS_TAB;
if (section === 'acp-agents') return DEFAULT_SETTINGS_TAB;
if (section === 'session-config') return 'session-personalization';
if (section === 'deep-review' || section === 'code-review' || section === 'review-team') return 'review';
if (section === 'shortcuts' || section === 'keybindings' || section === 'hotkeys') return 'keyboard';
Expand Down
8 changes: 1 addition & 7 deletions src/web-ui/src/app/scenes/settings/settingsTabSearchContent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,13 +99,7 @@ export const SETTINGS_TAB_SEARCH_CONTENT: Record<ConfigTab, readonly SettingsTab
{ ns: 'settings/mcp', key: 'section.serverList.description' },
],

'acp-agents': [
{ ns: 'settings/acp-agents', key: 'title' },
{ ns: 'settings/acp-agents', key: 'subtitle' },
{ ns: 'settings/acp-agents', key: 'registry.title' },
{ ns: 'settings/acp-agents', key: 'registry.description' },
{ ns: 'settings/acp-agents', key: 'json.title' },
],
// 'acp-agents': [ ... ], // nav entry temporarily hidden; omit from search index

editor: [
{ ns: 'settings/editor', key: 'title' },
Expand Down
Loading