Skip to content

fix the bug #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SWangHash merged 2 commits into from
Jun 17, 2026
Merged

fix the bug #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c31a972
fix(web-ui): remove duplicate feedback button in NavPanel footer
SWangHash Jun 17, 2026
2da4d7a
fix(tool-card): handle onClick prop in CompactToolCard
SWangHash Jun 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions src/web-ui/src/app/components/NavPanel/components/PersistentFooterActions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,15 +241,6 @@ const PersistentFooterActions: React.FC = () => {
<MessageCircle size={14} />
<span>{t('header.feedback')}</span>
</button>
<button
type="button"
className="bitfun-nav-panel__footer-menu-item"
role="menuitem"
onClick={handleFeedback}
>
<MessageCircle size={14} />
<span>{t('header.feedback')}</span>
</button>
<button
type="button"
className="bitfun-nav-panel__footer-menu-item"
Expand Down
17 changes: 11 additions & 6 deletions src/web-ui/src/flow_chat/tool-cards/CompactToolCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ export interface CompactToolCardProps {
export const CompactToolCard: React.FC<CompactToolCardProps> = ({
status,
isExpanded = false,
onClick,
onMouseDown,
onMouseUp,
onMouseMove,
Expand All @@ -48,12 +49,16 @@ export const CompactToolCard: React.FC<CompactToolCardProps> = ({
header,
expandedContent,
}) => {
const handleWrapperClick = (event: React.MouseEvent) => {
if (!onMouseUp || shouldIgnoreCardToggleClick(event)) {
const handleClick = (event: React.MouseEvent) => {
if (shouldIgnoreCardToggleClick(event)) {
return;
}

onMouseUp(event);
if (onClick) {
onClick(event);
} else if (onMouseUp) {
onMouseUp(event);
}
};

const loadingShimmer =
Expand All @@ -68,11 +73,11 @@ export const CompactToolCard: React.FC<CompactToolCardProps> = ({
<BaseToolCard
status={status}
isExpanded
onClick={handleWrapperClick}
onClick={handleClick}
className={`compact-tool-card-wrapper--expanded-card ${className}`.trim()}
header={header}
expandedContent={expandedContent}
headerExpandAffordance={clickable || Boolean(onMouseUp)}
headerExpandAffordance={clickable || Boolean(onClick) || Boolean(onMouseUp)}
/>
);
}
Expand All @@ -85,7 +90,7 @@ export const CompactToolCard: React.FC<CompactToolCardProps> = ({
className={`compact-tool-card status-${status} ${clickable ? 'clickable' : ''} ${isExpanded ? 'expanded' : ''}`}
onMouseDown={onMouseDown}
onMouseMove={onMouseMove}
onMouseUp={handleWrapperClick}
onMouseUp={handleClick}
style={{ cursor: clickable ? 'pointer' : 'default' }}
>
{header}
Expand Down
Loading