Skip to content

fix: resolve issue #1389 - Validate Feedback is Not Submitted on Cancelled Interviews #1390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sachinchaurasiya360 merged 2 commits into from
Jun 5, 2026
Merged

fix: resolve issue #1389 - Validate Feedback is Not Submitted on Cancelled Interviews #1390

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d7b50d
test: resolve Vitest constructor TypeError in PDFParse mock
sonusharma6-dsa Jun 4, 2026
ec62d54
fix: resolve issue #1389 - Validate Feedback is Not Submitted on Canc…
sonusharma6-dsa Jun 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 12 additions & 9 deletions server/src/module/ats/__tests__/ats.service.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,11 +106,12 @@ function mockCacheMiss() {

function mockValidPdf(text = VALID_RESUME_TEXT) {
vi.mocked(PDFParse).mockImplementation(
() =>
({
function () {
return {
getText: vi.fn().mockResolvedValue({ text }),
destroy: vi.fn().mockResolvedValue(undefined),
}) as any,
} as any;
}
);
}

Expand Down Expand Up @@ -183,11 +184,12 @@ describe("AtsService", () => {
mockUserOwnsResume();
mockCacheMiss();
vi.mocked(PDFParse).mockImplementation(
() =>
({
function () {
return {
getText: vi.fn().mockResolvedValue({ text: "too short" }),
destroy: vi.fn().mockResolvedValue(undefined),
}) as any,
} as any;
}
);

await expect(
Expand Down Expand Up @@ -466,11 +468,12 @@ describe("AtsService", () => {
it("throws when PDF text extraction yields insufficient content", async () => {
mockUserOwnsResume();
vi.mocked(PDFParse).mockImplementation(
() =>
({
function () {
return {
getText: vi.fn().mockResolvedValue({ text: "tiny" }),
destroy: vi.fn().mockResolvedValue(undefined),
}) as any,
} as any;
}
);

await expect(
Expand Down
4 changes: 4 additions & 0 deletions server/src/module/interview/interview.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,10 @@ export class InterviewService {
async addFeedback(recruiterId: number, id: number, feedback: { interviewerId: number; rating: number; strengths?: string | undefined; weaknesses?: string | undefined; notes?: string | undefined; recommendation: string }) {
const interview = await this.getById(recruiterId, id);

if (interview.status === "CANCELLED" || interview.status === "NO_SHOW") {
throw new Error("Cannot add feedback to a cancelled or no-show interview");
}

const existingFeedback = (interview.feedback as Record<string, unknown>[]) ?? [];
// Replace existing feedback from same interviewer or append
const filtered = existingFeedback.filter((f) => (f as { interviewerId?: number }).interviewerId !== feedback.interviewerId);
Expand Down
Loading