Skip to content

fix: resolve issue #1391 - Validate Rating Bounds in Interview Feedback #1392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sachinchaurasiya360 merged 1 commit into from
Jun 5, 2026
Merged

fix: resolve issue #1391 - Validate Rating Bounds in Interview Feedback #1392

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions server/src/module/interview/interview.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,10 @@ export class InterviewService {
throw new Error("Cannot add feedback to a cancelled or no-show interview");
}

if (feedback.rating < 1 || feedback.rating > 5) {
throw new Error("Rating must be between 1 and 5");
}

const existingFeedback = (interview.feedback as Record<string, unknown>[]) ?? [];
// Replace existing feedback from same interviewer or append
const filtered = existingFeedback.filter((f) => (f as { interviewerId?: number }).interviewerId !== feedback.interviewerId);
Expand Down
Loading