fix: resolve issue #1398 - Enable Checkout after Midnight for Shift Workers

[sonusharma6-dsa]

Closes #1398

[coderabbitai]

Warning

Review limit reached

@sonusharma6-dsa, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 16 minutes and 58 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3f93b743-2d9c-493c-b967-68fe9157674c

📥 Commits

Reviewing files that changed from the base of the PR and between e15a36c and 1a3effd.

📒 Files selected for processing (2)

• server/src/module/ats/__tests__/ats.service.test.ts
• server/src/module/attendance/attendance.service.ts

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Hi @sonusharma6-dsa, thanks for contributing to InternHack! 🎉

I have automatically:

• 👤 Assigned this PR to you.
• 🏷️ Applied the gssoc:approved label.

Our workflows will now analyze your changes to classify:

• 📈 PR Difficulty: level:*
• 🧩 PR Type: type:*
• 🌟 PR Quality: quality:*

Tip

Ensure your PR description references the issue it resolves (e.g. Closes #123). This allows the bot to inherit any additional labels from that issue!

Happy coding! 🚀

[Sachinchaurasiya360]

Code Review — PR #1399: Enable checkout after midnight for shift workers

Hi @sonusharma6-dsa, the shift-worker use case is valid and the fix is correct. One edge case to verify.

---

✅ Core logic is correct

Replacing:

// Before: only finds today's check-in
prisma.attendanceRecord.findUnique({ where: { employeeId_date: { employeeId, date: today } } })

With:

// After: finds the most recent unchecked-out record regardless of date
prisma.attendanceRecord.findFirst({
  where: { employeeId, checkOut: null },
  orderBy: { date: "desc" },
})

Using orderBy: { date: "desc" } ensures the most recent open record is matched, not an older forgotten one. This correctly handles the midnight crossover case.

---

🟡 Edge case: employee who never checked out from a previous day

With the new query, an employee who checked in three days ago and never checked out (e.g. forgot to mark attendance) will have their checkout applied to that 3-day-old record instead of being told "no active check-in."

This may or may not be desired behavior — document the intended policy. If you want to limit the look-back window, add a date floor:

const cutoff = new Date();
cutoff.setDate(cutoff.getDate() - 2); // max 2 days look-back
prisma.attendanceRecord.findFirst({
  where: { employeeId, checkOut: null, date: { gte: cutoff } },
  orderBy: { date: "desc" },
})

Otherwise, this is ready to merge.

[sonusharma6-dsa]

Code Review — PR #1399: Enable checkout after midnight for shift workers

Hi @sonusharma6-dsa, the shift-worker use case is valid and the fix is correct. One edge case to verify.

---

✅ Core logic is correct

Replacing:

// Before: only finds today's check-in
prisma.attendanceRecord.findUnique({ where: { employeeId_date: { employeeId, date: today } } })

With:

// After: finds the most recent unchecked-out record regardless of date
prisma.attendanceRecord.findFirst({
  where: { employeeId, checkOut: null },
  orderBy: { date: "desc" },
})

Using orderBy: { date: "desc" } ensures the most recent open record is matched, not an older forgotten one. This correctly handles the midnight crossover case.

---

🟡 Edge case: employee who never checked out from a previous day

With the new query, an employee who checked in three days ago and never checked out (e.g. forgot to mark attendance) will have their checkout applied to that 3-day-old record instead of being told "no active check-in."

This may or may not be desired behavior — document the intended policy. If you want to limit the look-back window, add a date floor:

const cutoff = new Date();
cutoff.setDate(cutoff.getDate() - 2); // max 2 days look-back
prisma.attendanceRecord.findFirst({
  where: { employeeId, checkOut: null, date: { gte: cutoff } },
  orderBy: { date: "desc" },
})

Otherwise, this is ready to merge.

Thanks for suggestion
I am working on it and resolving this..