fix: trim search query before API call to prevent whitespace-only DB hits (#1000)

[Xenon010101]

Fixes #1000

Summary by CodeRabbit

• Bug Fixes
  • Search functionality now properly handles leading and trailing whitespace in queries across repository and organization listings.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d409942a-5c66-4460-b2ff-59721fc7526c

📥 Commits

Reviewing files that changed from the base of the PR and between e15a36c and cb5d3f8.

📒 Files selected for processing (1)

• server/src/module/opensource/opensource.service.ts

---

📝 Walkthrough

Walkthrough

Two methods in the opensource service now trim the incoming search parameter before use: listRepos trims into trimmedSearch and getGsocOrgs trims into gsocTrimmedSearch. Both methods skip their OR-clause filters entirely when the trimmed value is empty, preventing whitespace-only searches from querying the database.

Changes

Search Parameter Trimming

Layer / File(s)	Summary
Trim search parameters in listRepos and getGsocOrgs server/src/module/opensource/opensource.service.ts	Both listRepos (lines 28–47) and getGsocOrgs (lines 115–120) now trim their search parameters into local variables and apply filter OR-clauses only when trimmed values are non-empty, using the trimmed values in all tag-match and text-filter expressions.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

• Sachinchaurasiya360/InternHack#894: Both PRs modify the Open Source search query construction around the search input—fix: open source search ignores language and only does exact case-sensitive tag matches #894 updates tag/language matching semantics, while this PR trims search and applies the same OR filtering logic only when the trimmed value is non-empty.

Suggested reviewers

• Sachinchaurasiya360

Poem

🐰 With spaces trimmed from search so fine,
No whitespace queries hit the line,
Both repos and orgs now skip the dance,
When trimmed to nothing—filter's chance!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description is minimal and references the linked issue, but omits most required template sections like detailed description, testing approach, and the completion checklist.	Expand the description to include implementation details, testing methodology, and complete the provided checklist items to ensure comprehensive documentation.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the main change: trimming search queries to prevent whitespace-only database hits, which directly matches the changeset.
Linked Issues check	✅ Passed	The code changes implement trimming in both required files (opensource.routes.ts and opensource.service.ts), addressing the whitespace-only search problem specified in issue #1000.
Out of Scope Changes check	✅ Passed	All changes are scoped to trimming search queries in the two specified files, directly addressing the linked issue requirements with no extraneous modifications.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Hi @Xenon010101, thanks for contributing to InternHack! 🎉

I have automatically:

• 👤 Assigned this PR to you.
• 🏷️ Applied the gssoc:approved label.

Our workflows will now analyze your changes to classify:

• 📈 PR Difficulty: level:*
• 🧩 PR Type: type:*
• 🌟 PR Quality: quality:*

Tip

Ensure your PR description references the issue it resolves (e.g. Closes #123). This allows the bot to inherit any additional labels from that issue!

Happy coding! 🚀