Skip to content

Fix accessibility for recruiter jobs empty state icon#1459

Open
Krithika1627 wants to merge 1 commit into
Sachinchaurasiya360:mainfrom
Krithika1627:fix/recruiter-empty-state-accessibility
Open

Fix accessibility for recruiter jobs empty state icon#1459
Krithika1627 wants to merge 1 commit into
Sachinchaurasiya360:mainfrom
Krithika1627:fix/recruiter-empty-state-accessibility

Conversation

@Krithika1627
Copy link
Copy Markdown
Contributor

@Krithika1627 Krithika1627 commented Jun 5, 2026

Pull Request

Description

Fixed an accessibility issue in the recruiter jobs empty state by marking the decorative briefcase icon as hidden from screen readers using aria-hidden="true".

Related Issue

Fixes #1161

Type of Change

  • Bug Fix
  • Feature
  • Enhancement
  • Documentation

Testing

  • Verified the empty state renders correctly.
  • Confirmed the decorative briefcase icon has aria-hidden="true".
  • Confirmed the adjacent heading provides context for screen reader users.

Checklist

  • Code follows project guidelines
  • No new compile/type errors
  • Tested manually (include steps above)
  • No .env, credentials, or node_modules committed
  • Docs updated (if needed)
  • Screenshot or video attached for every UI change

Summary by CodeRabbit

  • Bug Fixes
    • Improved accessibility by ensuring decorative icons are properly hidden from screen readers, providing a better experience for users with assistive technologies.

@github-actions github-actions Bot added bug Something isn't working gssoc level:beginner Good for first-time contributors quality:exceptional Exceptional implementation quality labels Jun 5, 2026
@github-actions github-actions Bot added type:accessibility Accessibility improvements type:bug Bug fixes type:design UI/UX or design-related updates gssoc:approved Approved for GSSoC scoring scope:frontend Changes to client-side / UI code labels Jun 5, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 5, 2026

Hi @Krithika1627, thanks for contributing to InternHack! 🎉

I have automatically:

  • 👤 Assigned this PR to you.
  • 🏷️ Applied the gssoc:approved label.

Our workflows will now analyze your changes to classify:

  • 📈 PR Difficulty: level:*
  • 🧩 PR Type: type:*
  • 🌟 PR Quality: quality:*

Tip

Ensure your PR description references the issue it resolves (e.g. Closes #123). This allows the bot to inherit any additional labels from that issue!

Happy coding! 🚀

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 5, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 133db2c5-4dd0-4225-95bd-14e322d862d8

📥 Commits

Reviewing files that changed from the base of the PR and between 0c176ae and a441f4e.

📒 Files selected for processing (1)
  • client/src/module/recruiter/jobs/RecruiterJobsList.tsx

📝 Walkthrough

Walkthrough

This PR adds aria-hidden="true" to the decorative Briefcase icon in RecruiterJobsList's empty state, preventing screen readers from announcing it as a meaningless graphic. The adjacent heading provides the context to users of assistive technologies.

Changes

Accessibility fix for empty-state icon

Layer / File(s) Summary
Decorative icon accessibility
client/src/module/recruiter/jobs/RecruiterJobsList.tsx
The Briefcase icon in the EmptyState component receives aria-hidden="true" to hide it from screen readers while the adjacent heading conveys the empty state message.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • Sachinchaurasiya360/InternHack#1291: Both PRs modify the internal EmptyState component inside RecruiterJobsList.tsx (this PR adds aria-hidden to the Briefcase icon for accessibility, while the other PR extends EmptyState with an onClear prop and "Clear filters" button).

Suggested labels

bug, type:accessibility, scope:frontend

Suggested reviewers

  • Sachinchaurasiya360

Poem

🐰 A briefcase hides from screen readers' sight,
No more confusing voices left and right—
The heading speaks for all to hear,
Accessibility's now crystal clear! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately and concisely describes the main change: fixing accessibility for the recruiter jobs empty state icon.
Description check ✅ Passed The description comprehensively covers all required sections including description, related issue, type of change, testing, and checklist items.
Linked Issues check ✅ Passed The PR directly addresses issue #1161 by adding aria-hidden="true" to the decorative briefcase icon as specified in the expected resolution.
Out of Scope Changes check ✅ Passed All changes are focused on the accessibility issue in the recruiter jobs empty state; no out-of-scope modifications detected.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working gssoc:approved Approved for GSSoC scoring gssoc level:beginner Good for first-time contributors quality:exceptional Exceptional implementation quality scope:frontend Changes to client-side / UI code type:accessibility Accessibility improvements type:bug Bug fixes type:design UI/UX or design-related updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[recruiter] Empty state icon in job list has no accessible text for screen readers

1 participant