fix: constrain student layout height so inner scroll containers work#1463
fix: constrain student layout height so inner scroll containers work#1463Xenon010101 wants to merge 2 commits into
Conversation
Adds green underline animation to heading heading, changes input/textarea backgrounds to bg-transparent to match glass-morphism card style. Closes Sachinchaurasiya360#1318 Signed-off-by: Xenon010101 <xenon010101@users.noreply.github.com>
Changes StudentLayout outer div to flex-col and main to flex-1 min-h-0 overflow-hidden, wrapping Outlet in a scrollable container. This allows child pages like JobAgentPage (which use flex-1) to properly constrain their height and scroll independently instead of the parent scrolling. Closes Sachinchaurasiya360#1452 Signed-off-by: Xenon010101 <xenon010101@users.noreply.github.com>
|
Hi @Xenon010101, thanks for contributing to InternHack! 🎉 I have automatically:
Our workflows will now analyze your changes to classify:
Tip Ensure your PR description references the issue it resolves (e.g. Happy coding! 🚀 |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR updates the Contact page UI with animated heading and transparent form fields, and restructures the StudentLayout scroll container to fix independent scrolling behavior of child content areas, directly addressing the Job Agent chat scroll issue. ChangesUI and Layout Updates
Estimated Code Review Effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly Related PRs
Suggested Labels
Suggested Reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 3❌ Failed checks (3 warnings)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What
Fix Job Agent chat messages area not scrolling independently — the parent layout scrolls instead.
Root cause
StudentLayout.tsx<main>hadoverflow-autobut no height constraint, soflex-1child pages couldn't constrain their height. The outer element scrolled instead of the inner messages container.Changes
StudentLayout.tsx: Made outerdivaflex-col, changed<main>toflex-1 min-h-0 overflow-hidden, wrapped<Outlet />in a scrollablediv.h-full.overflow-y-autoVerification
CI failures
N/A
Before
Parent
<main>scrolled when conversation grew — messages area had no independent scroll.After
Messages area scrolls independently; header and input bar remain fixed in place.
Closes #1452
Summary by CodeRabbit
New Features
Style