Skip to content

Make V29 migration DB-agnostic (following the style of the other migrations)#183

Open
SamuAlfageme wants to merge 7 commits intoSafeExamBrowser:dev-2.2from
SamuAlfageme:copilot/fix-v29-schema-agnostic
Open

Make V29 migration DB-agnostic (following the style of the other migrations)#183
SamuAlfageme wants to merge 7 commits intoSafeExamBrowser:dev-2.2from
SamuAlfageme:copilot/fix-v29-schema-agnostic

Conversation

@SamuAlfageme
Copy link
Copy Markdown

While discussing with the team from the UZH team some issues they were facing while upgrading their staging environment to v2.2, they faced an issue due to the fact that their DB was not named SEBServer in practice.

This PR drops the DB name from the script to make the migration DB-agnostic, since they already execute using a JDBC connection bound to a specific database/schema.

CC/ @anhefti

anhefti and others added 7 commits September 9, 2025 10:19
Bumps [urllib3](https://github.com/urllib3/urllib3) from 2.5.0 to 2.6.3.
- [Release notes](https://github.com/urllib3/urllib3/releases)
- [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst)
- [Commits](urllib3/urllib3@2.5.0...2.6.3)

---
updated-dependencies:
- dependency-name: urllib3
  dependency-version: 2.6.3
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
…t/pip/docs/urllib3-2.6.3

Bump urllib3 from 2.5.0 to 2.6.3 in /docs
@anhefti
Copy link
Copy Markdown
Member

anhefti commented May 7, 2026

Hi Sam

Thank you, yes this is wrong and problem when you don't have named your DB "SEBServer".
But unfortunately I cannot merge this pull request into the master branch. I need to merge it into the next patch branch dev-2.2. Since this change will also change the checksum of this migration task for flyway and I have to check how it behaves when changing on legacy setups.

How urgent is this change for you? Since we do not plan to release another patch for 2.2 before 3.0 is coming out; if you need a patch, please tell me, then I can make one for you.

Best
Andreas

@anhefti anhefti changed the base branch from master to dev-2.2 May 7, 2026 06:03
@SamuAlfageme
Copy link
Copy Markdown
Author

Hi @anhefti ! Thank you for picking this up so fast 🙏

How urgent is this change for you? Since we do not plan to release another patch for 2.2 before 3.0 is coming out; if you need a patch, please tell me, then I can make one for you.

Not urgent at all! We implemented a workaround to run the migrations manually on the staging DB, so you can merge this at your own peace (and even directly on v3). I opened the PR mostly not to forget if I run into this again in the future 😅

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants