Fix Issue #73: Configuration map not pushed in backup mode with --include-configuration-map#74
Merged
Conversation
…lude-configuration-map - Fix API filtering logic to properly handle backup mode - Add conditional overwriteConfigMap query parameter based on --include-configuration-map flag - Add comprehensive integration tests for both include-configuration-map scenarios - Update documentation with debugging and troubleshooting best practices - Comment complex boolean conditions for clarity Changes: - src/mirthsync/apis.clj: Fixed filtering and added query-params method for server-configuration - test/mirthsync/common_tests.clj: Added integration tests for Issue #73 - CLAUDE.md: Added debugging best practices section - .gitignore: Added .env and .mcp.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #73 where configuration map data was being pulled in FullBackup.xml but not pushed back to the server when using backup mode with
--include-configuration-map.Root Cause
:server-configurationAPI in some scenariosoverwriteConfigMap=truequery parameter required by Mirth's/server/configurationendpoint--include-configuration-mapflag was not being respected during push operations in backup modeChanges
src/mirthsync/apis.cljto properly handle backup modeoverwriteConfigMapquery parameter that respects the--include-configuration-mapflagTesting
--include-configuration-map=true--include-configuration-map=false