fix(mcp): secure HTTP bind and sync tool contract - #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
0.0.0.0plus signed-secret deployments compatibleCORE_TOOLS, includingresolution_presentationSecurity boundary
The Workbench gateway bearer token protects the gateway only. This change prevents an operator from exposing the underlying MCP listener without the signed principal context that Hosted deployments already provide.
Validation
uv run --no-sync --package sagasmith-dnd-mcp pytest packages/mcp/tests/test_streamable_http_runtime.py packages/mcp/tests/test_skill_contract_reference.py -quv run --no-sync --package sagasmith-dnd-mcp pytest packages/mcp/tests -quv run --no-sync ruff check packages/domain packages/mcpuv build --package sagasmith-dnd-mcp --out-dir .artifacts/distgit diff --check