Jobs submition with key#23
Open
mgorkii-nlplogix wants to merge 5 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates authentication-related flows to support passing a request-provided Salad API key through to Salad API calls (instead of always using env.SALAD_API_KEY), adjusts entitlement handling, and bumps the package version.
Changes:
- Add an optional
apiKeyparameter tolistContainerGroupsand use it for theSalad-Api-Keyheader. - Update
validateAuthto calllistContainerGroupswith the inbound Salad API key and adjust org resolution behavior. - Change entitlement handling in
validateSaladApiKeyfrom throwing to logging; bumppackage.jsonversion to0.7.1.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
src/utils/salad.ts |
Allow listContainerGroups to use a caller-supplied Salad API key for Salad requests. |
src/middleware.ts |
Pass request Salad API key into project validation; adjust entitlement behavior and org resolution logic. |
package.json |
Version bump to 0.7.1. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces minor improvements and bug fixes related to authentication and API entitlement checks, as well as updates to how API keys are handled when listing container groups. The changes enhance error logging, improve API key usage flexibility, and update the package version.
Authentication and API key handling:
listContainerGroupsto accept an optionalapiKeyparameter, allowing dynamic selection of the API key instead of always using the environment variable. This change is reflected in both the function signature and its usage inmiddleware.ts.Error handling and logging:
Version update:
0.7.0to0.7.1inpackage.jsonto reflect the new changes.