Repository navigation
Conversation
Signed-off-by: Chris Gianelloni <wolf31o2@blinklabs.io>
wolf31o2
requested review from
MIxAxIM,
Salvionied and
agaffney
as code owners
October 29, 2026 12:52
Signed-off-by: Chris Gianelloni <wolf31o2@blinklabs.io>
Collaborator
|
|
Resolve apollo.go: Sign and SignWithSkey run the body integrity check, then the fee limit check. Set a maximum fee on tests and doc examples added on main that call Complete or sign a loaded transaction. Signed-off-by: Chris Gianelloni <wolf31o2@blinklabs.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SetMaxFeebefore building or signing a transaction, and enforce it against the final fee including padding and absorbed change.SetMaxPaymentIncreasefor minimum-UTxO payment top-ups. Build outputs from payment copies so a failed attempt leaves the caller's amounts intact.Compatibility
Callers must set a maximum fee before
Complete()or signing a loaded transaction. CustomPaymentIimplementations must provide an independent copy throughPaymentCloner.