fix(security): resolve npm audit high-severity vulnerabilities#55
Merged
Conversation
npm audit --audit-level=high failed on CI for every open PR (esbuild via the deprecated @esbuild-kit chain, plus vite/ws/undici/form-data/multer), blocking the merge gate on changes that never touched the JS tree. `npm audit fix` (non-forced) updates only transitive resolutions in the lockfile — package.json manifest is unchanged, no direct-dep version bumps. Audit now reports 0 vulnerabilities. Verified: tsc clean, 257/257 tests pass, production build succeeds.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
npm audit --audit-level=high(the Dependency Audit CI check) was failing on every open PR — including the 5 Dependabot Python bumps (#50–#54) that never touch the JS tree. The failures are pre-existing npm-side vulnerabilities, so they block the merge gate regardless of a PR's content.CI flagged 6× high esbuild via the deprecated
@esbuild-kit/core-utils→@esbuild-kit/esm-loaderchain (GHSA-gv7w-rqvm-qjhr); the local tree also carried highs invite,ws/engine.io,undici,form-data,multer.What
npm audit fix(non-forced) — updates transitive resolutions inpackage-lock.jsononly.package.jsonmanifest unchanged — no direct-dependency version bumps, no API-surface risk.npm audit --audit-level=highnow reports 0 vulnerabilities.Verification
npm audit --audit-level=high→ 0 vulnerabilitiesnpx tsc --noEmit→ cleannpx vitest run→ 257/257 across 28 filesnpm run build→ vite + esbuild bundle succeedImpact
Unblocks the Dependency Audit gate for all 5 open Dependabot PRs (#50–#54) and any future PR. Merge this first.