Repository navigation
Conversation
…editing - A curl upload carries nobody's token, so curl may be on only while everyone may edit; the server refuses it otherwise (409) and switches it off when editing is closed - Ticking Curl upload with the pencil off now asks "Let everyone edit" first; agreeing opens editing and then curl, declining leaves curl off - Before, the box ticked but no commands appeared and uploads were refused, since every new room keeps editing to its host - Sessions saved with curl on and editing kept to the host load with curl off
- Turning the pencil off while curl upload is on now asks first, saying curl will be turned off too - Turn off closes both; Cancel leaves editing and curl as they were - With curl off the pencil still switches without a question
- Patch: curl upload needs everyone to be able to edit, and the pencil warns before taking curl with it - pyproject, app.py, package.json, both lockfiles and both README badges agree
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings
devto 2.2.1 with 3 commits: curl upload now works only while everyone may edit, and the host is asked before either switch takes the other with it.Backend
/session/toggle_curlrefuses to switch curl on while editing is kept to the host (409), since a curl upload carries nobody's token./session/toggle_editswitches curl off when it closes editing, and broadcastscurl_permission_changedwith it.Frontend
Checks
Test plan