Allow AudioNodes & AudioUnits to be !Send & !Sync#92
Draft
Smona wants to merge 11 commits intoSamiPerttu:masterfrom
Draft
Allow AudioNodes & AudioUnits to be !Send & !Sync#92Smona wants to merge 11 commits intoSamiPerttu:masterfrom
Smona wants to merge 11 commits intoSamiPerttu:masterfrom
Conversation
This enables the use of non-Send and non-Sync AudioUnits with `Net`. Advanced methods and operators which need to construct inner nodes are moved behind a new `NetUnit` trait, which is implemented for boxed units to provide backwards compatibility. The new trait enables users who aren't using trait objects to unlock this higher-level functionality by implementing the trait for their inner type. A `BoxedNet` type alias is provided which is backwards-compatible with the previous non-generic Net. Finally, this implements `AudioUnit` for any boxed type which implements `AudioUnit`, enabling the same impls to be reused between AudioUnit trait objects and concrete user types that directly `impl AudioUnit`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #91