Skip to content

Fix position/price_level type ambiguity in risk module #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SamoraDC merged 1 commit into from
Dec 12, 2025
Merged

Fix position/price_level type ambiguity in risk module #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions core/lib/risk/risk.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ let check_position_size ~symbol ~current_position ~order_qty ~order_side config
Approved

(** Check total exposure *)
let check_total_exposure ~positions ~order_value config =
let check_total_exposure ~(positions:position list) ~order_value config =
let total_exposure = List.fold_left (fun acc pos ->
Decimal.(acc + Decimal.abs pos.quantity)
) Decimal.zero positions in
Expand Down Expand Up @@ -131,7 +131,7 @@ let update_rate_limit t =
{ t with orders_last_minute = t.orders_last_minute + 1; last_order_time = now }

(** Main risk check function *)
let check_order ~(order:order) ~account ~positions ~current_position t =
let check_order ~(order:order) ~account ~(positions:position list) ~current_position t =
(* Check circuit breaker first *)
if t.circuit_breaker_active then
Rejected (Printf.sprintf "Circuit breaker active: %s"
Expand Down
Loading