Skip to content

Use a platform agnostic name for native libraries#1987

Closed
walac wants to merge 1 commit into
Samsung:masterfrom
expertisesolutions:walac/library-names
Closed

Use a platform agnostic name for native libraries#1987
walac wants to merge 1 commit into
Samsung:masterfrom
expertisesolutions:walac/library-names

Conversation

@walac

@walac walac commented Sep 4, 2020

Copy link
Copy Markdown
Contributor

This patch makes the DALi C# binder and tizenfx-stub library names
platform agnostic. This guarantees they can be loaded in Windows and
Linux environments.

@github-actions github-actions Bot added the API8 Platform : Tizen 6.0 / TFM : tizen80 label Sep 4, 2020
@walac walac force-pushed the walac/library-names branch from dff3328 to a68d729 Compare September 4, 2020 15:32
@WonyoungChoi WonyoungChoi changed the title Use a platform agnostic name for native libraries [Applications.Common] Use a platform agnostic name for native libraries Sep 7, 2020
@WonyoungChoi WonyoungChoi changed the title [Applications.Common] Use a platform agnostic name for native libraries Use a platform agnostic name for native libraries Sep 7, 2020
@WonyoungChoi

WonyoungChoi commented Sep 7, 2020

Copy link
Copy Markdown
Member

@HJLeee Is this available on the dotnet runtime in Tizen? Could you check the lookup algorithm of the runtime again?

@HJLeee

HJLeee commented Sep 7, 2020

Copy link
Copy Markdown
Contributor

@walac I wonder if you have tested it before the submittion as there is no devel pkg in the target and in such case there is no, for example, capi-xxx.so, which links to capi-xxx.so.0.

@walac

walac commented Sep 8, 2020

Copy link
Copy Markdown
Contributor Author

@HJLeee I tested it on Windows and Linux environments. Is there another test I should perform?

This patch makes the DALi C# binder and tizenfx-stub library names
platform agnostic. This guarantees they can be loaded in Windows and
Linux environments.
@walac walac force-pushed the walac/library-names branch from a68d729 to 0b4b743 Compare September 8, 2020 12:12
@WonyoungChoi

Copy link
Copy Markdown
Member

@walac You should test on the tizen platform also, The xxxx.so symbolic link files are usually not installed in the platform binaries.

@dongsug-song

Copy link
Copy Markdown
Contributor

@walac

walac commented Sep 24, 2020

Copy link
Copy Markdown
Contributor Author

Hi @dongsug-song , I can't access the links, are they behind some sort of a VPN or Firewall? I tried to take another approach to the problem following this dotnet documentation. The problem is that netstandard2.0 doesn't contain the referred APIs and the dllmap configuration is only implemented for mono.

PS: I have this PR pending for quite a while. Is this the right repo to submit?

@walac

walac commented Oct 13, 2020

Copy link
Copy Markdown
Contributor Author

Closing in favor of #2091

@walac walac closed this Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API8 Platform : Tizen 6.0 / TFM : tizen80 **NO MERGE**

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants