Repository navigation
refactor(banking): update wasabi_banking API calls to include accountType and source parameters - #327
Merged
Github-Samuel merged 1 commit intoNov 15, 2026
Conversation
…Type and source parameters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the wasabi_banking integration in
bridge/server/banking.lua.The bridge used an outdated wasabi_banking export signature, so with wasabi_banking as the banking provider:
Changes:
GetAccountBalance(id)→GetAccountBalance(id, 'bank')AddMoney/RemoveMoneynow use the current signature(accountType, accountID, amount, source)and return their result sotry()correctly detects successwasabi_bankingfromOWN_TABLE, since wasabi_banking stores the personal bank balance on the framework accountexports.wasabi_banking:Transaction(id, reason, amount, 'deposit'|'sent', 'personal'), using the phone's existing reason text (wrapped inpcallso logging can never block a transfer)Type of Change
Related Issues
None filed.
Testing
Tested on a Qbox server with the current wasabi_banking:
Wallet balance: showed $0 before the fix, the correct balance ($5,010) after
Transfer + statement-logging changes follow the same API and were reviewed against wasabi_banking's exports, but haven't been run end-to-end in a live transfer yet
Tested locally
Tested with latest sd-phone
Tested with latest ox_lib
Tested with latest ox_inventory
Multiplayer tested
Breaking Changes
No, for current wasabi_banking. Servers on a very old wasabi_banking that still used the previous
(identifier, amount, reason)export signature would need to update wasabi_banking. Other banking providers are untouched.Checklist