Repository navigation
Fix: give Plex guide titles a poster when Plex returns another entry - #162
Merged
Merged
Conversation
Plex finds a guide entry by its name key loosely, so "News" can return "News at Ten". When the entry it returns has another guid, find the entry's numeric id from batched id reads and write the poster there. The record stays under the name key, and only entries the name key reaches are probed for deleted uploads.
Deploying posteryard with
|
| Latest commit: |
3377c2c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://fda16b88.posteryard.pages.dev |
| Branch Preview URL: | https://fix-plex-guide-name-clash.posteryard.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
guide_iswithguide_target, which returns the key that reaches the guide entry with the show's guid, or nothing.Testing
Format, lint, type checks and the full suite pass. New tests cover the id search across batches with gaps, a guid that no id has, and uploads and re-selection by id without touching the other entry.
Checklist
DESIGN_VERSIONbumped andtests/goldenwritten again if rendered images change.CHANGELOG.mdupdated underUnreleasedfor user-visible changes.