Repository navigation
Add: publish the image to Docker Hub - #180
Merged
Merged
Conversation
The release pushes the same tags to docker.io/sandobserver/posteryard and then rewrites the Docker Hub page from README.md. The page update is its own workflow, so it also runs by hand. tools/dockerhub_description.py makes the links absolute, drops HTML that Docker Hub shows as text, names the Docker Hub image in commands and adds the image tags for the current version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docker.io/sandobserver/posteryard. The login runs before the build, so a missing token stops the release before anything is pushed.Docker Hub pageworkflow (manual run, and called by the release after a stable tag): checks the token logs in, then updates the Docker Hub overview and short description.tools/dockerhub_description.py: README.md as the Docker Hub overview, with a Markdown header, absolute links, no HTML, the Docker Hub image in commands and an Image tags section for the current version.Testing
All green. Added 7 tests for the overview: length limit, absolute links, no HTML outside code, Docker Hub image in commands, tags for the version, and refusals.
Checklist
DESIGN_VERSIONbumped andtests/goldenwritten again if rendered images change.CHANGELOG.mdupdated underUnreleasedfor user-visible changes.