Repository navigation
Docs: name the SSRF guard's real mechanism - #1
Merged
Merged
Conversation
architecture.md attributed the outbound guard to PRIVATE_IP_RE, which exists only as an independent comparison regex in a test file. The guard is isPrivateAddress, built from the BLOCKED_IPV4 CIDR table and BLOCKED_IPV6_RE. The category list was short as well: it named private, loopback and link-local but not carrier-grade NAT, multicast, reserved and broadcast, benchmarking or IETF protocol assignments, nor that localhost is refused by name and IPv4-mapped IPv6 forms are unwrapped before the check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PRIVATE_IP_REindocs/architecture.mdwithisPrivateAddress,BLOCKED_IPV4andBLOCKED_IPV6_RE, the identifiers that exist inapi/src/proxy.js.PRIVATE_IP_REis a hand-written comparison regex inapi/test/demo.test.js, used as a second opinion on the guard.localhostis refused by name and that IPv4-mapped IPv6 forms are unwrapped before the check.Testing
All green. No new tests: documentation only, and every identifier named was verified to exist in
api/src/proxy.js.Checklist