Repository navigation
Docs: correct three claims that no longer match the code - #11
Merged
Merged
Conversation
The frontend guide told contributors the widget `?v=` was manual and to bump it when a widget's files changed. It has not been manual since entryVersions: the release hashes each entry file into the manifest and widget-types.js reads it from there, so following the guide meant hand-editing a value the build owns. Two tests pin the mechanism. The contributor guide claimed no test dependencies while c8 and Playwright are installed. The Playwright config claimed tests for drag reordering, focus and Persian mirroring; the five specs cover listing, adding, editing, reload persistence and widget type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/frontend.md: replace the claim that the widget?v=is manual. The release hashes each widget's entry files intoentryVersionsin itswidget.json, andui/js/widget-types.js:59reads the hash from there when it builds the iframe URL.ui/test/cache-busting.test.mjs: one assertingwidget-types.jsstill reads the manifest hash and that no literal?v=stamp appears in a widget URL, one asserting the guide's Cache busting section namesentryVersionsand no longer says the value is manual.CONTRIBUTING.md: the unit runner needs nothing installed, but coverage (c8) and the browser tests (Playwright) use the root dev tooling.playwright.config.js: the header claimed coverage of drag reordering, focus handling and Persian mirroring. The five specs cover listing seeded apps, adding, editing, reload persistence and widget type; the header now says so and names the gaps.Testing
All green. Added 2 tests; mutation-checked by restoring the "is manual" wording and by planting a literal widget stamp, each of which fails.
Checklist