Repository navigation
Improve: size the values on a small System Summary tile to the space they have - #129
Merged
Merged
Conversation
…they have Adding a label per row shrank the values on the assumption that they had to make room. A small tile is a 170px canvas, so the container query never reaches the clamp and its minimum is the size that renders. A 9px label and a 1px gap leave about 24px for a value once the network row is on, so the figures were smaller than the layout required.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A small tile renders on a 170px canvas, so the container-query term in the clamp never applies and the minimum is what renders. With a 9px label and a 1px gap, a four-row tile has roughly 36px per row and 24px of that is available to the value, so the earlier sizes were smaller than the layout called for. These are larger than before labels were added, and stay inside the room a tile with the network row showing actually has.
Testing
All green. Verified in a container at both small layouts, with and without the network row.
Checklist