Repository navigation
Fix: stop reporting apps unhealthy while Docker health checks are off - #131
Merged
Merged
Conversation
Skip the container half of /api/health when no socket proxy address is configured, and omit items that end up with no check at all. Keep the per-app health toggle usable in that state so a URL check still works and an app's check can be turned off.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/api/healthwhen no socket proxy address is configured, so container-backed apps are no longer reported unhealthy.app.healthGlobalOffin all six catalogs to state that only container checks need the global setting.Testing
All green. Added 2 backend tests covering the health route with no socket proxy configured.
Checklist