Skip to content

Fix: stop reporting apps unhealthy while Docker health checks are off - #131

Merged
SandObserver merged 1 commit into
mainfrom
fix/health-badge-when-docker-off
Aug 20, 2026
Merged

SandObserver merged 1 commit into
mainfrom
fix/health-badge-when-docker-off

Conversation

@SandObserver

Copy link
Copy Markdown
Owner

Summary

  • Skip the container lookup in /api/health when no socket proxy address is configured, so container-backed apps are no longer reported unhealthy.
  • Omit items from the health response when neither a container nor a ping check runs for them.
  • Keep the per-app health toggle interactive while Docker container health checks are off, so a URL check still works and the check can be switched off.
  • Reword app.healthGlobalOff in all six catalogs to state that only container checks need the global setting.

Testing
All green. Added 2 backend tests covering the health route with no socket proxy configured.

Checklist

  • Stays within the project constraints: one container, no runtime dependencies, no build step (see CONTRIBUTING.md).
  • Tests added or updated for new logic, and the full suite, lint, and typechecks pass.
  • Docs updated if behavior or configuration changed.
  • CHANGELOG.md updated under Unreleased if the change is user-visible.

Skip the container half of /api/health when no socket proxy address is
configured, and omit items that end up with no check at all. Keep the
per-app health toggle usable in that state so a URL check still works and
an app's check can be turned off.
@SandObserver SandObserver added the bug Something isn't working label Aug 20, 2026
@SandObserver
SandObserver merged commit a9f730e into main Aug 20, 2026
4 checks passed
@SandObserver
SandObserver deleted the fix/health-badge-when-docker-off branch August 20, 2026 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant