Repository navigation
Fix: accept a hex color typed without its leading hash - #132
Merged
Merged
Conversation
Detect an invalid CSS color with two seeded fillStyle reads, so an unparseable value no longer resolves to black. Add the leading hash to a bare 3 to 8 digit hex code in the color control and in the background color field, and warn when a value is not a color.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fillStylereads, so_cssToHexreturns null for an unparseable value instead of the seeded black.normalizeColorInput, which supplies a missing leading#for a bare 3 to 8 digit hex code and reports whether the value parses at all.toast.colorInvalidto all six catalogs.Testing
All green. Added 5 frontend tests for the parser and the normaliser, and updated the case that pinned black for an unreadable value.
Checklist