Repository navigation
Fix: allow a drop between two folders in the admin list - #133
Merged
Merged
Conversation
Split a folder row into three drop zones. The top and bottom quarter reorder and show the insert line; the middle half still drops into the folder. Both the pointer and the touch drag paths pass targetIsFolder only for the middle zone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
folderRowZonetoadmin-drag-logic.js, splitting a folder row into an above/into/below zone with a quarter-height edge at each end.dragoverhandler and in the touchplacehandler, so an edge zone showsdrag-above/drag-belowinstead ofdrag-into.targetIsFolderonly when the pointer is in the middle zone.Testing
All green. Added 3 frontend tests for the zone split and for a reordering drop on a folder row.
Checklist