Repository navigation
Fix: use the Persian terms shipped software uses - #168
Merged
Merged
Conversation
The Persian catalogue reached for dictionary coinages that translated dashboards do not use, and named one concept two ways. درونریزی and برونبری for import and export appear in none of Immich, Jellyfin or Uptime Kuma. All three build import on وارد کردن, and Immich ships وارد کردن پیکربندی for "Import configuration" and خروجی for "Export". A widget was both ابزارک and ویجت, and a file both فایل and پرونده, in the same interface. One message left the English word "Import" inside the Persian, which the coverage test could not see because the value as a whole differs from the English. Two headings read as adjectives rather than as what is about to happen. The glossary is recorded in docs/i18n.md, and a test fails on any of the rejected terms in the dashboard catalogue or any widget catalogue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Importleft insidetoast.importNoChange.importForeign.willAddandwillCreate, which read as adjectives rather than as the action about to be taken.REJECTEDgate toi18n-coverage.test.mjsthat fails on any superseded term, in the dashboard catalogue and in every widget catalogue, so a bulk retranslation cannot reintroduce one.docs/i18n.mdbeside the existing term table, with the sources it was taken from.Testing
All green: 1081 frontend tests, 1334 backend tests at 94.35% lines, lint, format, both typechecks, the cache-busting check, and the Docker build. Added 1 test, verified to fail by reintroducing a rejected term before reverting.
Checklist