Repository navigation
Fix: pluralise the counted messages nothing had converted - #171
Merged
Merged
Conversation
The plural work converted the messages that already carried a singular and a
plural key. It never looked for counted messages that had never been pluralised
at all, so the import confirmation and the badge label limit still counted in
English.
Both are now stored per plural category. Two others the scan turns up are left
alone with a reason: "{count} pending" is a participle and agrees with nothing
in any language shipped here, and "every {seconds} seconds" wraps an editable
field whose minimum is 10, so the surrounding words would have to be rebuilt on
every keystroke to reach a singular that cannot occur.
A test now finds a number followed by a plural noun with no plural forms, which
is what nothing was looking for.
Adds browser coverage for choosing a language: the choice saves, survives a
reload, reaches the dashboard and the widget frames, and sets the direction.
The pseudolocale is checked for what it was built for, that no control clips
when every string is 40% longer, at desktop and at 390px wide, in both browsers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
import.confirmandapp.labelMaxinto per-category plural forms across all six locales, renaming their{n}placeholder to{count}and updating the three call sites.every counted noun has plural formstoi18n.test.mjs, matching a placeholder followed by a plural noun, withNOT_COUNTEDcarrying a reason per exclusion.app.pollInterval, which is split around an editable field with a minimum of 10; reaching its singular would mean rebuilding the surrounding words on every keystroke.status.pendingis not matched, being a participle that agrees with nothing in the six shipped languages.e2e/localisation.spec.js: choosing a language in Settings saves it, survives a reload, reaches the dashboard and the widget frame URL, and setsdirfor Persian.en-XArenders and is absent from the selector,cimoderenders keys, and neither is written to the config.en-XAand fail on any control overflowing without an ellipsis, at desktop and at 390px, skipping visually-hidden text.Testing
All green: 1088 frontend tests, 1334 backend tests at 94.35% lines, lint, format, both typechecks, the cache-busting check, and the Docker build. The full e2e suite was run in Chromium and WebKit against the built image; the 20 new cases pass in both. Added 1 unit test and 10 e2e cases.
One pre-existing failure, unrelated to this change:
spotlight-contrast.spec.js"the search placeholder clears 4.5:1 over a light wallpaper" fails under WebKit in the Playwright container. It fails identically onmainwith the same command, and passes in CI, so it looks specific to that WebKit build rather than to the page.Checklist