Repository navigation
Fix: translate the text widgets write themselves - #173
Merged
Merged
Conversation
The Pull Requests caption and both clock date lines rendered English on every translated dashboard. Route the caption through the widget catalog and format the clock date with Intl. Add a check that scans every widget for display text written without a lookup, so the same class of miss fails the suite.
SandObserver
added
bug
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Stripping tags to find words reads as a sanitiser and matches js/incomplete-multi-character-sanitization. The scan only needs to tell prose from markup, so it skips a literal that carries either.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wt('view.prs.label')instead of a hardcoded English literal.Intl.DateTimeFormat, replacing the hardcoded English day and month arrays. The accessible label already used Intl.textContentwithout a catalog lookup, skipping injected stylesheets, markup and interpolated values.Testing
All green, plus the Docker build. Added 3 tests covering the widget text scan, the clock date formatting and the caption lookup across all six locales.
Checklist