Repository navigation
Fix: take a label's ellipsis side from the name in Safari - #175
Merged
Merged
Conversation
unicode-bidi:plaintext moves the cut in Blink and is ignored by WebKit, where a Latin name on a right-to-left dashboard was clipped at both ends. The labels are centred, so the direction can go on the block itself.
SandObserver
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dir="auto"on.ilabel,.dyn-mob-label,.dyn-fold-labeland.dyn-fold-inner-labelat each creation site, so a label takes its direction from the name it holds.unicode-bidi:plaintextrules added in Fix: cut a tile label at the end of its own name #174. They move the cut in Blink and are ignored by WebKit, where the label was clipped at both ends and read "...ckup and St".dircannot move a name off its own icon, which is why the attribute is safe here and not on the Settings rows.Testing
All green, plus the Docker build. Added 2 tests, verified to fail without the change, and confirmed the rendering in WebKit and Blink against a container running this commit.
Checklist