Repository navigation
Refactor: drop the undocumented errors log level alias - #25
Merged
Merged
Conversation
The threshold table carried a fifth name the rank table never had. It appears in no documentation, no UI offers it, and the settings route validates the stored value against debug, info and error, so it was reachable only by setting LOG_LEVEL to it by hand. warn and error keep their shared threshold. The Settings tip describes that behaviour and a test pins it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
errorskey from the log threshold table, leaving the four level names the rank table already defines.errorlevel.The removed name was documented nowhere, offered by no UI, and rejected by the settings route, which validates the stored value against
debug,infoanderror. It was reachable only by settingLOG_LEVEL=errorsby hand.errordeliberately keeps the same threshold aswarn: the Settings tip reads "Errors shows warnings and errors only", so raising it would silently drop warnings for every install that selected it. The new test pins that.Testing
All green, including the Docker build. Added 2 tests; the documented level list is derived from the rank table, so it was unaffected.
Checklist