Skip to content

Refactor: drop the undocumented errors log level alias - #25

Merged
SandObserver merged 1 commit into
mainfrom
refactor/log-threshold-alias
Aug 10, 2026
Merged

SandObserver merged 1 commit into
mainfrom
refactor/log-threshold-alias

Conversation

@SandObserver

Copy link
Copy Markdown
Owner

Summary

  • Remove the errors key from the log threshold table, leaving the four level names the rank table already defines.
  • Add a test pinning the accepted names, and one pinning that warnings still emit at the error level.

The removed name was documented nowhere, offered by no UI, and rejected by the settings route, which validates the stored value against debug, info and error. It was reachable only by setting LOG_LEVEL=errors by hand.

error deliberately keeps the same threshold as warn: the Settings tip reads "Errors shows warnings and errors only", so raising it would silently drop warnings for every install that selected it. The new test pins that.

Testing
All green, including the Docker build. Added 2 tests; the documented level list is derived from the rank table, so it was unaffected.

Checklist

  • Stays within the project constraints: one container, no runtime dependencies, no build step (see CONTRIBUTING.md).
  • Tests added or updated for new logic, and the full suite, lint, and typechecks pass.
  • Docs updated if behavior or configuration changed. No documentation referenced the removed name.
  • CHANGELOG.md updated under Unreleased if the change is user-visible. Not user-visible: the name was unreachable through any documented or offered path.

The threshold table carried a fifth name the rank table never had. It appears
in no documentation, no UI offers it, and the settings route validates the
stored value against debug, info and error, so it was reachable only by
setting LOG_LEVEL to it by hand.

warn and error keep their shared threshold. The Settings tip describes that
behaviour and a test pins it.
@SandObserver SandObserver added the refractor Code improvement / cleanup, no behavior change label Aug 10, 2026
@SandObserver
SandObserver merged commit fb1e83d into main Aug 10, 2026
4 checks passed
@SandObserver
SandObserver deleted the refactor/log-threshold-alias branch August 10, 2026 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refractor Code improvement / cleanup, no behavior change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant