Repository navigation
Fix: stop the importer losing sections and refusing valid configs - #36
Merged
Merged
Conversation
The YAML subset refused a flow collection only after a key, so one written as a sequence element parsed into a mapping built from its brace and first key, and the section vanished from the import with no skip recorded. The anchor refusal tested the whole line, including values, so ordinary text containing * or & refused the file. A sequence element indented with more than one space after the dash threw on its continuation keys. The converters passed over a malformed top-level group and a Dashy section carrying no readable items, both without recording a skip, so a mangled file imported smaller than it was with nothing in the preview saying why. The dialog focus trap listened on the dialog element, which cannot hold focus, so a click on text inside it sent Escape and the Tab wrap to the document and neither worked. The backdrop dismissed on any click ending on it, including a text selection released past the edge of the dialog.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{or[throughscalarbefore the key matcher, so a flow collection refuses with its line number instead of parsing into a mapping made from its brace and first key.*and&inside a value stay text.indent + 2.foldBlockrather than trimming trailing blank lines inscan, so+keeps every trailing newline, and drop the empty string a final newline leaves behind in the row split.SKIP.UNREADABLEfor a Homepage top-level group that is not a list and for a Dashy section carrying neither items nor widgets.Setof taken ids directly incollectorinstead of copying it.trapFocuskeydown listener to the document in the capture phase, since the trapped root holds text that cannot take focus.openModal'sfocus()is armed again.localUrlcomment to the branch it describes and drop a subsumedstartsWithtest, a subsumed tab pattern and an unuseddepthparameter.Testing
All green, except the Docker build smoke test, which has no local Docker and is left to CI. Added 11 tests for the modal in a new
ui/test/modal.test.mjs, 7 for the parser refusals and block chomping, and 5 for the skips the converters now record.Checklist