Repository navigation
Security: scope certificate skipping and shorten sessions - #37
Merged
Merged
Conversation
Turning certificate verification off is now decided in one place and only ever applies to a host on the local network. The server-wide setting was already scoped that way; the per-app switch and the per-request flag were handed straight to the transport, and those are the paths that carry a stored credential. Session tokens now expire after 12 hours idle rather than 30 days, and a session still in use is reissued once it is past halfway, so the shorter window bounds an unused token without signing anyone out mid-task.
The seeding helper posts through an API request context, which is not a page and so states no origin. Writes now require one, which refused every seed. The address comes from the same definition the Playwright config resolves relative paths against, so the two cannot drift apart.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolveSkipTls), applying the existing internal-host restriction to the per-itemskipTlsVerifyflag and the per-requestskipTlsfield, not just the server-wide setting.readTokenandrefreshSession.Originheader, rather than allowing it through.passwordSetandsetupPromptedfrom/api/auth/checkunless the caller is authenticated.skipTlsVerifyacross a foreign-config import, viainsecureAppsandclearSkipTlsand a checkbox in the import preview; reuse the existingapp.allowSelfSignedandapp.selfSignedTipstrings so no catalog gains a key.Testing
All green, plus a live check against a public host with a self-signed certificate. Added 22 tests: certificate-skip scoping across both outbound paths, session renewal and expiry, the origin requirement, the pre-auth reply, and the import decision.
Checklist