Repository navigation
Fix: check the socket proxy address and steady the icon preview - #42
Merged
Merged
Conversation
The Docker socket proxy address was stored exactly as typed and never contacted. A wrong address looked configured while every app checked by container name reported down, since a container that cannot be found counts as not running, and the reason appeared only in the container log. POST /api/docker/test probes the address for a Docker API and separates one that is wrong from one that is merely not answering yet, so a proxy still starting does not block an otherwise correct save. The icon preview in the app editor redrew with the app list's fixed image size, which filled the smaller tile and lost its inset, and each keystroke started a load whose late failure reset the tile, so a name held its placeholder until it had been saved and drawn once on its own.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST /api/docker/test, which probes an address for a Docker API via/versionand reports whether it is usable.pingErrorTextanderrCodefrom the proxy so the probe reuses the existing error-code vocabulary.docker-compose.ymlcomment with the placeholder used elsewhere.Testing
All green. Added 9 tests for the socket proxy probe and 2 for the icon preview.
Checklist