Skip to content

Fix: check the socket proxy address and steady the icon preview - #42

Merged
SandObserver merged 1 commit into
mainfrom
fix/icon-preview-and-socket-check
Aug 12, 2026
Merged

SandObserver merged 1 commit into
mainfrom
fix/icon-preview-and-socket-check

Conversation

@SandObserver

Copy link
Copy Markdown
Owner

Summary

  • Add POST /api/docker/test, which probes an address for a Docker API via /version and reports whether it is usable.
  • Separate a wrong address (refused connection, unresolvable name, unreachable network, non-Docker service, 4xx) from one that is only not answering yet, so a timeout warns instead of refusing.
  • Refuse the General save when Docker monitoring is on and the probe rejects the address, alongside the existing password refusals and before any write.
  • Report an unverified address as a warning once the save has landed, rather than in place of it.
  • Export pingErrorText and errCode from the proxy so the probe reuses the existing error-code vocabulary.
  • Drop the fixed 30px image size from the app editor's icon preview redraw, leaving the stylesheet's proportional rule to size it in the 34px tile.
  • Number preview attempts so a late failure from a superseded keystroke cannot reset the tile to the letter placeholder.
  • Document why every container-checked app can turn red at once, and why a socket proxy service name and a published port are not interchangeable addresses.
  • Replace a real LAN address in a docker-compose.yml comment with the placeholder used elsewhere.

Testing
All green. Added 9 tests for the socket proxy probe and 2 for the icon preview.

Checklist

  • Stays within the project constraints: one container, no runtime dependencies, no build step (see CONTRIBUTING.md).
  • Tests added or updated for new logic, and the full suite, lint, and typechecks pass.
  • Docs updated if behavior or configuration changed.
  • CHANGELOG.md updated under Unreleased if the change is user-visible.

The Docker socket proxy address was stored exactly as typed and never
contacted. A wrong address looked configured while every app checked by
container name reported down, since a container that cannot be found counts
as not running, and the reason appeared only in the container log.

POST /api/docker/test probes the address for a Docker API and separates one
that is wrong from one that is merely not answering yet, so a proxy still
starting does not block an otherwise correct save.

The icon preview in the app editor redrew with the app list's fixed image
size, which filled the smaller tile and lost its inset, and each keystroke
started a load whose late failure reset the tile, so a name held its
placeholder until it had been saved and drawn once on its own.
@SandObserver SandObserver added the bug Something isn't working label Aug 12, 2026
@SandObserver
SandObserver merged commit 4e089ef into main Aug 12, 2026
4 checks passed
@SandObserver
SandObserver deleted the fix/icon-preview-and-socket-check branch August 12, 2026 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant