Repository navigation
Fix: keep the wallpaper and the current page across a reload - #45
Merged
Merged
Conversation
Every config save bumps _rev, which reloads every open dashboard. Each reload asked Unsplash for a new random photo and reset the page index. Cache the resolved wallpaper URL in localStorage for a day, keyed to the background type and collection, and restore the page index on load.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
localStoragefor 24 hours, keyed to the background type and collection, so a reload reuses the same photo instead of calling/api/wallpaperagain.localStorageand restore it on load, clamped to the pages that exist, for both the desktop and mobile builds.announceparameter togoToso the page restored on load is not read out by the live region.Testing
All green, apart from the Docker build smoke test, which needs a local Docker daemon. Added 8 tests for the wallpaper cache and the page restore, and 1 asserting the restored page is not announced.
Checklist