Repository navigation
Fix: name ALLOW_PRIVATE_IPS when a badge is blocked as private - #46
Merged
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
A badge pointed at a private address fell through to the generic branch, which shows the SSRF reason and nothing else. Add the setting that allows it, for the two private-address reasons only.
SandObserver
force-pushed
the
fix/blocked-private-ip-advice
branch
from
August 12, 2026 20:11
5b03ea0 to
7df4af6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
KIND.BLOCKEDcontextual advice inbadgeErrorAdvicewhen the reason is a private address, matching the treatmentNETWORKandTIMEOUTalready get.ALLOW_PRIVATE_IPS=truewould let through, keep the original reason in the text, and return the warn tone instead of the error tone.Testing
All green, apart from the Docker build smoke test, which needs a local Docker daemon. Added 2 tests, one for both private-address reasons and one asserting the other blocked reasons are unchanged.
Checklist